illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.
Other
11 stars 19 forks source link

Add Robin BC to diffusion operator #993

Closed tulioricci closed 6 months ago

tulioricci commented 7 months ago

Adds Robin BC for the diffusion operator. Tests were conducted using the added example adv-diff-react.py to verify convergence of the expected value at the boundary, summarized at the table below. I don't know if it would be good to add a similar analysis in one of the test due to extra computational time in CI for running multiple cases to assess convergence. Nonetheless, a test was added to exercise all diffusion BCs in one single case.

N order error EOC
50 2 0.0008709114852747195 xxx
100 2 0.00011054282974628119 2.977920649395854
200 2 1.3870643546230384e-05 2.9862097342798877
50 3 0.00011080654857500696 xxx
100 3 1.3872582248482454e-05 2.9977348843336182
200 3 1.735537998486721e-06 2.998258191684584
50 4 4.6491903854575965e-07 xxx
100 4 1.473154291711964e-08 4.979999060829744
200 4 4.619611653505728e-10 4.987496106746617

Questions for the review: