Debug axis tagging. - Githubissues

illinois-ceesd / mirgecom

MIRGE-Com is the workhorse simulation application for the Center for Exascale-Enabled Scramjet Design at the University of Illinois.

Other

12 stars 19 forks source link

Debug axis tagging. #999

Closed MTCam closed 7 months ago

MTCam commented 7 months ago

Debugging session for fallback warnings in mirgecom

Questions for the review:

[ ] Is the scope and purpose of the PR clear?
- [ ] The PR should have a description.
- [ ] The PR should have a guide if needed (e.g., an ordering).
[ ] Is every top-level method and class documented? Are things that should be documented actually so?
[ ] Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
[ ] Does the implementation do what the docstring claims?
[ ] Is everything that is implemented covered by tests?
[ ] Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

matthiasdiener commented 7 months ago

Currently with this PR, the following examples have the warning (Falling back to a slower transformation strategy as some loops are uninferred which mesh entity they belong to.) still:

[x] ablation-workshop
[x] advection_diffusion_reaction
[x] blasius
[x] heat-source
[x] sod

MTCam commented 7 months ago

Most of the examples were fixed by the changes we made to componentwise_norms and compare functions in simutils.

heat-source switched to use the alrready-fixed componentwise_norms instead of actx.np.la.norm

advection_diffusion_reaction, ablation-workshop are fixed after fixing up 1d normal returns in grudge/geometry/metrics.py with axis tags. blasius is working after local_dt fixed to do something different in simutils to avoid the fallback compile. sod fixed by avoiding calls to h_min_from_volume.