Migrate query request to Broadway endpoints to be direct - Githubissues

illinois-cs241 / broadway-on-demand

Webapp that facilitates on-demand assignment autograding via Broadway.

Other

11 stars 4 forks source link

Migrate query request to Broadway endpoints to be direct #132

Closed Xiangmingchen closed 3 years ago

Xiangmingchen commented 3 years ago

Before adding the integration for broadway job position SSE, I wanted to migrate our existing query requests.

Before this migration

Any status query request (such as grading job status or queue position) must use on-demand server as a middle man to avoid leaking tokens.

on-demand client -> on-demand server -> broadway -> on-demand server -> on-demand client

This slows down performance by half and is especially slow for queue position query (which need to make 2 such trips).

After this migration

Now the on-demand client can use query tokens to make direct requests

on-demand client -> broadway -> on-demand client

TODO

[x] Don't merge until this broadway PR is deployed
[x] Add query_token to each class in both on-demand and broadway before merging

Testing

Tested with a local on-demand and broadway cluster.