search

illinois-cs241 / broadway

A distributed systems framework used running distributable workloads.
Other
18 stars 0 forks source link

Merge broadway-api and broadway-grader #1

Closed zhengyao-lin closed 5 years ago

zhengyao-lin commented 5 years ago

Proposed merge for https://github.com/illinois-cs241/broadway-api/issues/75

I used code from these two branches(top of the config branches in both repos)

not sure if this project structure is the best practice 🤔

zhengyao-lin commented 5 years ago

hmm I think that will break the imports. Also if this is going to be installed as a package the package name should probably start with broadway

ayushr2 commented 5 years ago

Oh so this is supposed to be installed as a package... so then what would the usage look like for the grader and the API?

zhengyao-lin commented 5 years ago

Ah no not necessarily I was just saying it seem to make more sense to keep the full name of the package. The usage looks like python3 -m broadway.api and python3 -m broadway.grader

ayushr2 commented 5 years ago

Gotcha. cc @nmagerko what do you think.

nmagerko commented 5 years ago

I think having them under a broadway dir is fine