illinois-or-research-analytics / cm_pipeline

Pipeline that uses an improved version of CM for generating well-connected clusters
GNU General Public License v3.0
5 stars 4 forks source link

Checking input to cm.py #35

Closed chackoge closed 1 year ago

chackoge commented 1 year ago

I think it would be helpful if the input to cm.py (post-filtering) was checked for whether the tsv file contained no rows. The script should print a message and halt.

ytabatabaee commented 1 year ago

same thing should probably be done before the analysis step: if the output of cm+filtering was an empty clustering, the script should halt (rather than producing error)

vikramr2 commented 1 year ago

Added extra checks to halt the pipeline on an error. CM also will just output an empty clustering if given an empty clustering. Error messages are more informative too

*** Starting filtering STAGE ***
Currently on resolution 0.5, running 2 iterations
[1] "OK 3 params supplied"
[1] "OK 3 params supplied"
Stage 2 Time Elapsed: 00:00:00
*** DONE ***
*** Starting connectivity_modifier STAGE ***
Currently on resolution 0.5, running 2 iterations
Stage 3 Time Elapsed: 00:00:02
*** DONE ***
*** Starting filtering STAGE ***
Currently on resolution 0.5, running 2 iterations
[1] "OK 2 params supplied"
Error: Error: Clustering is empty.
Execution halted
res-0.5-i2/S4_cit_hepph_lfr_leiden.0.5_i2_post_cm_filter.R.tsv failed to generate

Marking this as resolved