search

illinois-scicomp / machine-shop-maintenance

Scripts and Issues for the birds and the beers
10 stars 3 forks source link

Suggestion: add `gh` package #58

Closed matthiasdiener closed 2 years ago

matthiasdiener commented 2 years ago

(I'm happy to do it if it is considered interesting)

lukeolson commented 2 years ago

Sounds good to me. Just add a few lines here https://github.com/illinois-scicomp/machine-shop-maintenance/blob/main/update.sh

inducer commented 2 years ago

Looks like this was done in bb8248dd76e65549cdb79aba9ba8146871e85a5c.

@matthiasdiener What procedure did you use to apply these changes? (There is one!)

matthiasdiener commented 2 years ago

Looks like this was done in bb8248d.

@matthiasdiener What procedure did you use to apply these changes? (There is one!)

I haven't applied these yet aside from committing https://github.com/illinois-scicomp/machine-shop-maintenance/commit/bb8248dd76e65549cdb79aba9ba8146871e85a5c. I only found https://github.com/illinois-scicomp/machine-shop-maintenance/issues/54#issuecomment-1024753762 regarding a procedure to apply these changes, and got a bit scared ;-)

inducer commented 2 years ago

Good point. 670318fa4db8e687f3b76d6dddb6ed1dd4b698d6 (LMK if unclear)

FWIW, I ran the script earlier today, so this should now be applied.

matthiasdiener commented 2 years ago

Thank you!