search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 37 forks source link

fixed location queue notification lists empty location #110

Closed trombonekenny closed 6 years ago

trombonekenny commented 6 years ago

I created a fixed location queue and enabled notifications (Win10, Chrome). When something was added to the queue, I got a notification but it had a blank Location: field.

Shouldn't that have the fixed queue mentioned, or perhaps drop the Location: mention at all?

nwalters512 commented 6 years ago

I would say omit the location, since course staff controls + knows the location? Does that make sense?

trombonekenny commented 6 years ago

Or leave it in for consistency in the notifications, but at least fill it in with the right data. I'm okay with either fix.

redsn0w422 commented 6 years ago

I'm working on this - I think having the location filled in even if it's fixed-location makes more sense.