search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 36 forks source link

Hide confidential queue information over API and websockets #224

Closed nwalters512 closed 5 years ago

nwalters512 commented 5 years ago

This is my first attempt at ensuring students can't see the information of other students via the API or websocket updates. I added tests for the API endpoints to ensure they behave correctly. Did my best to share code when possible. I've tested this with some local queues and everything seems to be working correctly. A second set of eyes to make sure I didn't miss any endpoints or weird edge cases would be appreciated!

Thankfully, this doesn't seem to have required any changes to the frontend! Everything "just works" when it receives less information than usual. Thanks to @jackieo5023 for that awesome work 🎉

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

nwalters512 commented 5 years ago

Ope, great catch. Want to file an issue for exploring websocket testing?