Refine dark mode - Githubissues

illinois / queue

A microservice queue for holding open office hours

University of Illinois/NCSA Open Source License

82 stars 36 forks source link

Refine dark mode #279

Closed nwalters512 closed 5 years ago

nwalters512 commented 5 years ago

Extend styles with slightly tweaked colors for buttons, alerts, etc. based on DashKit.
Add a page for admins where they can preview how a variety of Bootstrap components look with our themes.
Use explicit path for darkmode cookie to avoid differing settings between pages.

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

jackieo5023 commented 5 years ago

I just realized this is on master too, but when you create a queue, the text shows up as white, as well as the background when choosing a course.

nwalters512 commented 5 years ago

Never caught that because Chrome on macOS with system-wide dark mode enabled displays things differently. I can reproduce on Firefox though. I'll see if I can tie #253 into the fix for that.

nwalters512 commented 5 years ago

oops just realized I forgot a changelog entry. you failed the test 😛

jackieo5023 commented 5 years ago

AHHH NOOO