search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 36 forks source link

Typescript support! #281

Closed nwalters512 closed 5 years ago

nwalters512 commented 5 years ago

Following up on #220. This PR by no means converts fully to TypeScript, but it does add it to our toolchain so that we can incrementally add types in the future. The build process is a little wonky given that Next doesn't support transpiling server files itself (see https://github.com/zeit/next.js/issues/1735) so we have to work around that. I'm going to write docs explaining what I did and why I did it so that if problems come up in the future, future maintainers have something to go off of.

TODO

vercel[bot] commented 5 years ago

This pull request is automatically deployed with Now. To access deployments, click Details below or on the icon next to each push.

nwalters512 commented 5 years ago

Did my best to add a suitable linting config for TypeScript - there's a bit of weird duplication of some rules between JS and TS and I had to add some overrides since there's not great built-in support for dual-language projects in typescript-eslint. Lmk how things look to you!