Cancelling the creation of a new queue causes a form validation error

illinois / queue

A microservice queue for holding open office hours

University of Illinois/NCSA Open Source License

82 stars 36 forks source link

Open PradyumnaShome opened 5 years ago

PradyumnaShome commented 5 years ago

Steps to reproduce Create queue -> Cancel queue

Expected Behavior Modal disappears

Current Behavior

Form validation errors - "you must select a course, and enter a name", and then the modal disappears.
Address bar has remnants of create queue action - "https://queue.illinois.edu/q/?course=&name=&location="

nwalters512 commented 5 years ago

Good catch! Probably due to type="submit" on the cancel button in components/NewQueue. That blame falls solely on me 😢