search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 36 forks source link

Is now/vercel a hard dependency? #330

Open joshuata opened 3 years ago

joshuata commented 3 years ago

There are a lot of files hanging around for deployment/CI using vercel/now. Working to bring these up to date has revealed several backwards-incompatible changes that are going to take some effort to resolve. Do we know of anyone actually using these, or can those dependencies be dropped?

@james9909 @nwalters512

nwalters512 commented 3 years ago

It's not a hard dependency at all, just a convenience that makes it easy to test PRs. Can you elaborate on which "lots of files" and "several backwards-incompatible changes" you're referring to?

joshuata commented 3 years ago

Currently the now/next build steps are failing. If you run npm build on the pending PR #328, the next build ./nextbuild command throws a bunch of errors related to typescript incompatibilities

nwalters512 commented 3 years ago

I'm unable to reproduce that over on https://github.com/illinois/queue/pull/331, though I do see a different Vercel-related error:

should NOT have additional property `scale`

It's important to note the difference between Vercel (formerly Now), a deployment platform, and Next.js, a React meta-framework built by Vercel. The former is used just for PR deployment previews, the latter is the core framework upon which the queue is built.

It seems like Vercel finally shut down v1 of their deployment platform, which we were using; I think that's the root cause of the above error. I'm going to drop the now.json file and disconnect the repo from Vercel.

Let me know if you still see TS errors after https://github.com/illinois/queue/pull/331 lands, I can look into those in isolation!