search

illinois / queue

A microservice queue for holding open office hours
University of Illinois/NCSA Open Source License
82 stars 37 forks source link

Add database migrations setup #56

Closed nwalters512 closed 6 years ago

nwalters512 commented 6 years ago

Supersedes #52. This now uses Sequelize's built-in support for migrations.

This PR includes a CI step which verifies that running all migrations in order produces a schema that matches the schema specified by the Sequelize models. This prevents the merging of a PR that modifies the Sequelize models without also including a corresponding migration.

shreyas208 commented 6 years ago

What's verifydb.sh? Seems to be an empty file.

nwalters512 commented 6 years ago

good catch, that was left from an earlier iteration. I removed it.

shreyas208 commented 6 years ago

Changes look good 👍 Looks like prettier is not happy though.

nwalters512 commented 6 years ago

Rip, looks like my pre-commit hook hasn't been running. I'll fix this later.