illinoisdata / DeepOLA

7 stars 5 forks source link

Refactor repository #106

Closed pyongjoo closed 2 years ago

pyongjoo commented 2 years ago

I will first draft a proposal and ask @nikhil96sher to review.

Once confirmed, I will create a PR accordingly.

pyongjoo commented 2 years ago

Current directory structure:

baselines
|--postgres
|--presto
|--resources
|--wanderjoin
|
data 
|
deepola
|
rust
|--runtime (top level rust project)
|
scripts

New proposed data structure

baselines (same)
|--postgres
|--presto
|--resources
|--wanderjoin
|
data (no change)
|
deepola (a top-level including multiple sub-projects; rust workspace)
|--wake (previously runtime; rust package)
|--wake-dist (not created yet; part of future plan)
|--wake-sql (not created yet; part of future plan)
|
scripts (no change)

See this page for rust workspace.

nikhil96sher commented 2 years ago

The overall structure looks good to me. One additional thing that needs to be refactored is resources directory. Now, resources wouldn't be specific to the current runtime package or baselines. So, should we move the resources to the outermost data directory (either keeping it data or renaming to resources).

pyongjoo commented 2 years ago

@nikhil96sher That's a good point. I will see if our tests can use the resource/data directory outside the project. If so, I will move data files (like tpch data files) to the top-level data directory.