illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.
MIT License
544 stars 31 forks source link

Performance when moving the window is terrible #10

Closed illegitimate-egg closed 1 year ago

illegitimate-egg commented 2 years ago

I literally cannot move my vscode windows with this theme applied.

illixion commented 2 years ago

Hi, sorry for the delay, could you please provide the following info:

jmgomez commented 2 years ago

Same here. I personally know another person with the same problem.

Win 10 VSCode 1.70.2 The theme doesnt really matter as it happens with all of them. 3070 RTX

illegitimate-egg commented 2 years ago

Windows 10 1.70.2 Dark+ Nvidia GEFORCE GTX 1650

illixion commented 2 years ago

I haven't been able to reproduce this issue, but it's likely caused by some other software. If someone can find any possible cause, let me know and I'll see if I can figure out a fix.

You can also use GlassIt-VSC to achieve transparency in the meantime.

GetGet99 commented 2 years ago

Hello! I go and edit the file [VSCode Install Root]\resources\app\out\vscode-vibrancy-runtime-v6\index.js

I commented win10refresh(window, 60); and window moving is fine. I'm not sure if it will break the previous version of Windows. Tested on Windows 11

    if (app.os === 'win10') {
        const bindings = require('./vibrancy.js');
        bindings.setVibrancy(window.getNativeWindowHandle().readInt32LE(0), 1, backgroundRGB.r, backgroundRGB.g, backgroundRGB.b, 0);
        const win10refresh = require('./win10refresh.js');
        // win10refresh(window, 60);

        window.webContents.once('dom-ready', () => {
            const currentURL = window.webContents.getURL();

            if (!(currentURL.includes('workbench.html') || currentURL.includes('workbench-monkey-patch.html'))) {
                return;
            }

            if (window.isMaximized()) {
                window.unmaximize();
                window.maximize();
            }
        });
    }

image

illixion commented 2 years ago

Hello! I go and edit the file [VSCode Install Root]\resources\app\out\vscode-vibrancy-runtime-v6\index.js

I commented win10refresh(window, 60); and window moving is fine. I'm not sure if it will break the previous version of Windows. Tested on Windows 11

  if (app.os === 'win10') {
      const bindings = require('./vibrancy.js');
      bindings.setVibrancy(window.getNativeWindowHandle().readInt32LE(0), 1, backgroundRGB.r, backgroundRGB.g, backgroundRGB.b, 0);
      const win10refresh = require('./win10refresh.js');
      // win10refresh(window, 60);

      window.webContents.once('dom-ready', () => {
          const currentURL = window.webContents.getURL();

          if (!(currentURL.includes('workbench.html') || currentURL.includes('workbench-monkey-patch.html'))) {
              return;
          }

          if (window.isMaximized()) {
              window.unmaximize();
              window.maximize();
          }
      });
  }

image

Hi,

Thank you for finding a solution, would anyone in this thread like to test this on Windows 10? I'll implement this change if it works and doesn't break anything.

bug-author commented 1 year ago

I faced the same issue on Windows 10. I updated my vscode to the latest version (1.71.1) and now its working fine.

illixion commented 1 year ago

I faced the same issue on Windows 10. I updated my vscode to the latest version (1.71.1) and now its working fine.

Good to hear, thanks for reporting this. Could someone else from this thread update their VSCode and confirm that this issue is fully fixed and isn't an isolated case?

illixion commented 1 year ago

Closing as stale, feel free to comment if this issue is still present.

ghost commented 1 year ago

The issue persists on vsc1.74 win10 165hz. Commenting out win10refresh(window, 60); didn't do much for me.