illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.
MIT License
572 stars 31 forks source link

[Bug]: Not working on mac os #128

Closed SiddharthMathurDeveloper closed 7 months ago

SiddharthMathurDeveloper commented 9 months ago

Is there an existing issue for this?

Current Behavior

Screenshot 2024-02-06 at 10 52 59 PM

not working

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:Mac os latest one
- VSCode:
- Extension:
- Theme:

Anything else?

No response

illixion commented 9 months ago

Please fill out the Environment field, especially the macOS and VSCode versions as well as the currently selected theme.

SiddharthMathurDeveloper commented 9 months ago

extra info "vscode_vibrancy.theme": "Dark (Only Subbar)", "workbench.colorCustomizations": { }, "workbench.colorTheme": "Ayu Dark"

illixion commented 9 months ago

Looks like you’re using an unsupported VSCode theme (Ayu Dark), please check the list of supported themes in the description.

TheFanatr commented 9 months ago

Same issue here. Same environment as OP but on macOS Sonoma 14.3. This just happened with the latest update of Code; worked perfectly fine before.

{
    "vscode_vibrancy.opacity": 0,
    "vscode_vibrancy.type": "ultra-dark"
    "workbench.colorTheme": "Monokai"
}
mklebrasseur commented 9 months ago

Same issue here. Same environment as OP but on macOS Sonoma 14.3. This just happened with the latest update of Code; worked perfectly fine before.

{
    "vscode_vibrancy.opacity": 0,
    "vscode_vibrancy.type": "ultra-dark"
    "workbench.colorTheme": "Monokai"
}

Just when I was starting to enjoy VS Code 🤣, I also confirm that Vibrancy breaks with the latest update to vs code 1.86.1.

Worked perfectly prior to updating.

illixion commented 9 months ago

@TheFanatr can you post your current Vibrancy Continued version? The issue is because you're using the ultra-dark vibrancy type, which was deprecated in VSCode 1.86, and Vibrancy is supposed to detect that and ask you to change it to under-window.

mklebrasseur commented 9 months ago

I've tried under-window and auto. I know this is directly for @TheFanatr but my version of Vibrancy is 1.1.27. If you prefer I open my own issue I am happy to do so!

{
  "vscode_vibrancy.opacity": 0,
  "vscode_vibrancy.theme": "GitHub Dark Default",
  "vscode_vibrancy.type": "under-window"
}
illixion commented 9 months ago

@mklebrasseur No worries, could you try reinstalling VSCode perhaps? Also, are you using any extensions that modify VSCode's files like APC or VSCode Animations?

mklebrasseur commented 9 months ago

@mklebrasseur No worries, could you try reinstalling VSCode perhaps? Also, are you using any extensions that modify VSCode's files like APC or VSCode Animations?

I disabled all plugins, I do not have APC or VSCode Animations installed. While looking at the console logs I can Vibrancy is initialized and no other errors are observed.

I did attempt a reinstall last evening but some files were still lingering. I will attempt it again and report back!

mklebrasseur commented 9 months ago

@illixion a full uninstall and clearing of some lingering cache folders / saved states seems to have restored the functionality!

Thanks!

Rey-Wang commented 9 months ago

@illixion might related to this issue, on my mac, it looks like this image

is it also caused by the cache?

current commented 9 months ago

@illixion a full uninstall and clearing of some lingering cache folders / saved states seems to have restored the functionality!

Thanks!

what folders did you have to delete? im having troubles aswell, deleted the application support folder for Code and ~/.vscode

mklebrasseur commented 9 months ago

@illixion a full uninstall and clearing of some lingering cache folders / saved states seems to have restored the functionality! Thanks!

what folders did you have to delete? im having troubles aswell, deleted the application support folder for Code and ~/.vscode

@current I ran through the following

  1. Close and Quit VSCode

  2. Remove VScode from Applications (just go to Finder -> Applications and move VSCode to Bin)

  3. Execute these commands in any order. The paths might be slightly different for you.

    rm -fr ~/.vscode*
    rm -fr ~/Library/Application\ Support/Code/
    rm -fr ~/Library/Saved\ Application\ State/com.microsoft.VSCode.savedState/
    rm -fr ~/Library/Preferences/com.microsoft.VSCode.helper.plist 
    rm -fr ~/Library/Preferences/com.microsoft.VSCode.plist 
    rm -fr ~/Library/Caches/com.microsoft.VSCode
    rm -fr ~/Library/Caches/com.microsoft.VSCode.ShipIt/
  4. Reinstall VSCode

mhjiang97 commented 9 months ago

@illixion might related to this issue, on my mac, it looks like this image

is it also caused by the cache?

The same for me. Have you found a way to fix this? Thanks.

kamilali commented 9 months ago

@illixion might related to this issue, on my mac, it looks like this image is it also caused by the cache?

The same for me. Have you found a way to fix this? Thanks.

@Rey-Wang and @mhjiang97 - I had this issue as well. The solution was to make sure that the theme you have for VSCode doesn't inherit from system theme (if you're on auto) and is not set to light theme. It seems to work properly only with dark theme. Hope that works for yall!

mhjiang97 commented 9 months ago

@kamilali THANK YOU~

illixion commented 7 months ago

Closing as stale.