illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.
MIT License
506 stars 27 forks source link

[Bug]: auto dark mode wrong behavior #147

Closed rainbowflesh closed 2 months ago

rainbowflesh commented 2 months ago

Is there an existing issue for this?

Current Behavior

QQ截图20240505182958

  1. When system change to light/dark mode with VS Code running, extension will notify theme changed and pop up reload dialog; but after restart, the "config is changed" dialog will pop up again with change back to opposite theme.
  2. When system change to light/dark mode without VS Code running, extension won't prompt change to light/dark mode.

Expected Behavior

A light/dark mode check after VS Code start up will help?

Steps To Reproduce

  1. close vscode.
  2. change system theme.
  3. run vscode.

Environment

- OS: win11
- VSCode: newest release
- Extension: alot
- Theme: rosepine

Anything else?

{
"vscode_vibrancy.theme":"light",
"vscode_vibrancy.preferedLightTheme":"light",
"vscode_vibrancy.preferedDarkTheme":"dark",
"window.autoDetectColorScheme":true
}
MrOxMasTer commented 2 months ago

The github theme is breaking too

image

LiPingYen commented 2 months ago

The solarized dark + is broken.

CleanShot 2024-05-05 at 20 58 49@2x

zedle commented 2 months ago

Same here with Catppuccin Mocha. If I set the theme again it will work until I load a new folder, reload the workspace, or restart vscode, then it breaks again.

Fefedu973 commented 2 months ago

Same

LouisRaverdy commented 2 months ago

Same issue here, the only workaround is downgrading the version on install. Waiting for a fix

illixion commented 2 months ago

Apologies all, pushed some faulty code, version .31 has the fix

LouisRaverdy commented 2 months ago

Nice ! Thank you for your great extension !

illixion commented 2 months ago

The Vibrancy theme setting needs to be restored to what it was before as the previous value would've been lost, unfortunately

Fefedu973 commented 2 months ago

The Vibrancy theme setting needs to be restored to what it was before as the previous value would've been lost, unfortunately

Yup. Only issue. It seems that now the window control isn't working (cannot click on the maximize button and cannot snap the window on the sides)

illixion commented 2 months ago

Yup. Only issue. It seems that now the window control isn't working (cannot click on the maximize button and cannot snap the window on the sides)

If you’re on Windows, you may be encountering this bug: https://github.com/illixion/vscode-vibrancy-continued/issues/140