illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.
MIT License
557 stars 32 forks source link

[Bug]: Background is too vibrant #46

Open mvahaste opened 1 year ago

mvahaste commented 1 year ago

Is there an existing issue for this?

Current Behavior

The backdrop is too vibrant, it looks like I have digital vibrance at 100% for VSCode only.

Here's a screenshot I took:

Current

Expected Behavior

Backdrop should be less vibrant.

Here's a screenshot my friend took (same wallpaper):

Expected

Steps To Reproduce

  1. Install vibrancy.

It's happened every time I've used this extension, even on a fresh windows install, but never to my friends. I've also tried disabling all other extensions, changing themes and looking through my NVIDIA control panel settings.

I have had this problem for a long time, even back when I used the original vibrancy extension. It's probably something on my end, but I'm just hoping that creating an issue will at least give me some new leads.

Environment

- OS: Windows 11 22H2
- VSCode: 1.73.1
- Extension: 1.1.12

Anything else?

No response

illixion commented 1 year ago

Hey, I've noticed this too on my PC with an Nvidia GPU, you could try disabling GPU rendering for VSCode and seeing if that fixes this. Follow this instruction: https://stackoverflow.com/a/58762168

mvahaste commented 1 year ago

Hey, I've noticed this too on my PC with an Nvidia GPU, you could try disabling GPU rendering for VSCode and seeing if that fixes this. Follow this instruction: stackoverflow.com/a/58762168

I tried this and unfortunately it doesn't work. I should also probably mention that I have an RTX 2060 in my main PC and my laptop has Intel HD Graphics 520, I have this issue on both machines.

Also, the friend who sent the screenshot has an RTX 3070, another friend has a GTX 1080, no issues for either of them. This makes me think that it's gotta be something on my end, some setting or configuration, but I've no idea what it could be, as it persists even after a Windows reinstall.

KAGEYAM4 commented 1 year ago

i am having the same issue, can you try get your friends vscode installation ( like vscode has a portable mode guide, just tell him to send you the required files) and run it in your environment , this will help isolate the issue.

KAGEYAM4 commented 1 year ago

@mvahaste i think i found it , first confirm from your friend is he using MicaForEveryone .

I am using MicaForEveryone -- > Steps -->

  1. Click on Add Rule ( left bottom)
  2. Add Process Rule
  3. Enter "Code"
  4. Leave everything to default except , go to bottom and enable "blur Behind" image image
osadasami commented 1 year ago

@PhoenixCODE2322

could you share what vibrancy settings you use? I use Opacity: 0.1 Theme: defaul dark Type: auto and can't get blur effect like on your screenshot, only a little blur

2022-12-13_09-10-52

In Mica For Everyone I use only blur Behind And I use windows 11

KAGEYAM4 commented 1 year ago

I have the same settings as yours --> Also i don't know but i installed this (maybe it helped , you can try) -- > dotnet-sdk-3.1.425-win-x64 image image

mvahaste commented 1 year ago

@mvahaste i think i found it , first confirm from your friend is he using MicaForEveryone .

I am using MicaForEveryone -- > Steps -->

  1. Click on Add Rule ( left bottom)
  2. Add Process Rule
  3. Enter "Code"
  4. Leave everything to default except , go to bottom and enable "blur Behind" image image

Hi, my neither of my friends use MicaForEveryone, it just works out-of-the-box for them.

I can confirm that this workaround does help, thanks. It's still a little off but definitely not too vibrant like it was before.

ZeChArtiahSaher commented 1 year ago

Mica sucks because upon launch or window snap blur gets killed (at least on NV). Also only works with Extend Frame Into Client Area

MaksimKosyanchuk commented 1 year ago

I have the same problem, I found 2 .cc files in the extension folder, and manually changed the contrast, but I don’t know where to compile these files, who knows how these C++ files work in the extension?

sthephanno1 commented 1 year ago

same problem This is how blur is supposed to look like image This is how it looks image i think when i first used win11 in august last year, NVidia cards had a problem rendering the acrylic and it looked exactly like the one from this extension, oversaturated and with not much blur

MaksimKosyanchuk commented 1 year ago

same problem This is how blur is supposed to look like image This is how it looks image i think when i first used win11 in august last year, NVidia cards had a problem rendering the acrylic and it looked exactly like the one from this extension, oversaturated and with not much blur

I don't have a nvidia video card, and the same problem, it's not related to the video card

parazite7 commented 1 year ago

Yeah it looks terrible, the problem is with the vibrancy theme. When on solarized dark vibrancy theme the colours are slightly better. We need a theme with a pure acrylic background like the terminal below. (or even better a setting that lets you tweak the background colour) 1

rainbowflesh commented 11 months ago

This issue is also a commonplace, I have made many attempts, and the results all point to, ah, It's a feature on Windows, unfixable if windows not expose more upper-level API.

Reference: https://github.com/EYHN/vscode-vibrancy/issues/112 https://github.com/MicaForEveryone/MicaForEveryone/issues/359

a0w89fwa0f commented 3 months ago

Any updates on this? Why do some people have the issue but others don't?