[Feature]: Automatic Theme based on light/dark mode in OS

illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.

MIT License

557 stars 32 forks source link

[Feature]: Automatic Theme based on light/dark mode in OS #51

Closed arimal199 closed 5 months ago

arimal199 commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe.

No response

Describe your idea or feature request

No response

Describe alternatives you've considered

No response

Anything else?

No response

bigplayer-ai commented 1 year ago

This is a must feature, But I think it should follow VSCODE theme and not OS theme:

switch vibrancy to light mode+ when VScode theme is switched.
or dark mode+ when VScode theme is switched.
All based on VScode theme.

There is native VSCODE follow OS theme setting, just search theme preferred in settings and enable that feature: window.autoDetectColorScheme "window.autoDetectColorScheme": false

The only part left for the extension is to adjust itself based on VSCode theme.

bigplayer-ai commented 1 year ago

Hey, Can you implement this?

illixion commented 1 year ago

This isn’t something that I’m personally interested in implementing as I use VSCode exclusively in dark mode, so don’t expect it to be implemented any time soon, but pull requests are always welcome. Perhaps this can be done using a CSS media query and the VSCode setting you’ve mentioned.

rainbowflesh commented 11 months ago

There was an example https://github.com/danielgjackson/vscode-auto-dark-mode-windows/blob/master/extension.js

I would give a try later.

illixion commented 5 months ago

Implemented in PR #146 and available in version 1.1.30