search

illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.
MIT License
557 stars 32 forks source link

[Bug]: Fix WIki vscode_vibrancy.opacity Opacity of Vibrancy Effect. value must be: -1 ~ 0 and not 0 ~ 1 #57

Closed bigplayer-ai closed 1 year ago

bigplayer-ai commented 1 year ago

Is there an existing issue for this?

Current Behavior

[Bug]: Fix WIki vscode_vibrancy.opacity Opacity of Vibrancy Effect. value must be: -1 ~ 0 and not 0 ~ 1

Expected Behavior

[Bug]: Fix WIki vscode_vibrancy.opacity Opacity of Vibrancy Effect. value must be: -1 ~ 0 and not 0 ~ 1

Steps To Reproduce

[Bug]: Fix WIki vscode_vibrancy.opacity Opacity of Vibrancy Effect. value must be: -1 ~ 0 and not 0 ~ 1

Environment

- OS:
- VSCode:
- Extension:
[Bug]:  Fix WIki vscode_vibrancy.opacity Opacity of Vibrancy Effect.  value must be: -1 ~ 0 and not 0 ~ 1

Anything else?

[Bug]: Fix WIki vscode_vibrancy.opacity Opacity of Vibrancy Effect. value must be: -1 ~ 0 and not 0 ~ 1

illixion commented 1 year ago

This is wrong, correct values are 0.0 to 1.0.

ShayBox commented 1 year ago

This should be put on the text of the setting, I had to find this closed issue to figure out that it's not 0-100 like most transparency/opacity settings.

An even better improvement would be auto-range scaling, if the input is > 1 adjust the scale to 0-100

This is not clear what it should be, it doesn't even come populated with a setting and gives an error. image

illixion commented 1 year ago

@ShayBox I've implemented input validation on this field, meaning that you'll get an error if it's not a number between -1 and 1. Not sure why it wasn't populated on your end, it's defined to have a default value of -1, meaning that it'll use the theme's setting for opacity instead.