illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.

MIT License

516 stars 27 forks source link

Support for .ipynb #79

Closed okayama-daiki closed 1 year ago

okayama-daiki commented 1 year ago

Overview

Fixed an issue raised in #62 where the background was not transparent in .ipynb files. (left: original, right: fixed)

Fixes

I directly edited the following css in the /themes directory.

Default Dark.css
Default Light.css
Noir et blanc.css
Solarized Dark+.css
Tokyo Night Storm.css
Dark (Exclude Tab Line).css

The following css has been added to each file.

.notebookOverlay.notebook-editor,
.cell-statusbar-container,
.margin-view-overlays,
.monaco-list-row:hover:not(.selected):not(.focused) {
  background-color: transparent !important;
}

Detail

The correspondence of the selectors of the changed css is as follows.

.notebookOverlay.notebook-editor
- Entire display of the .ipynb file
.cell-statusbar-container
- Status bar in the notebook cell
.margin-view-overlays
- Left side of the code block in the notebook cell (e.g. where the breakpoint is set)
.monaco-list-row:hover:not(.selected):not(.focused)
- when hovering over the notebook cell

Environment

macOS v13.4.1 (22F82)
Visual Studio Code v1.79.2

illixion commented 1 year ago

Looks good, thanks for the contribution and the well-written PR!