[Bug]: Minimize/ Max/ Close button in the title bar doesn't get the vibrancy effect

illixion / vscode-vibrancy-continued

Enable Acrylic/Glass effect for your VS Code.

MIT License

557 stars 32 forks source link

[Bug]: Minimize/ Max/ Close button in the title bar doesn't get the vibrancy effect #93

Closed beetrandahiya closed 1 year ago

beetrandahiya commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

The minimize/ Max/ Close button in the title bar doesn't get the vibrancy effect, giving i a weird look over such beautiful theme.

Expected Behavior

The buttons should show vibrancy effect

Steps To Reproduce

No response

Environment

- OS: Windows 11
- VSCode: 1.81.1
- Extension: 1.1.20
- Theme: auto

Anything else?

illixion commented 1 year ago

This issue is caused by "Native Window Controls" VSCode setting being enabled by default, the extension is supposed to turn if off automatically, but it seems like it sometimes fails to do so. Will need to investigate that further.

beetrandahiya commented 1 year ago

I can find such a setting although i found these, and turned them both to custom, but nothing changed

illixion commented 1 year ago

You're right, the setting was renamed at some point, it's now called "Window Controls Overlay"

beetrandahiya commented 1 year ago

Yea, that worked, thanks

whr3430633 commented 9 months ago

You're right, the setting was renamed at some point, it's now called "Window Controls Overlay"

There is no setting named "Window Controls Overlay" in my case... 😢 Windows 11 23H2 22631.2861 Vscode 1.85.1 Extension 1.1.24

illixion commented 9 months ago

@whr3430633 please see https://github.com/illixion/vscode-vibrancy-continued/issues/49 for info on why it’s missing

whr3430633 commented 9 months ago

@whr3430633 please see #49 for info on why it’s missing

got it, thanks 👍