illogical-robot / apkmirror-public

APKMirror.com bugs
http://www.apkmirror.com
111 stars 32 forks source link

Auto inserted Google ads in release listings prevent info buttons from working #130

Closed MihirGosai closed 4 years ago

MihirGosai commented 4 years ago

Expected behavior

All results should collapse on click of info(i) icon

Actual behavior

Unable to collapse 3rd search result (APK) Screenshot_20200519-211138_Chrome

Steps to reproduce the problem

Visit https://www.apkmirror.com/?post_type=app_release&searchtype=apk&s=My+talking

archon810 commented 4 years ago

I can't reproduce this. There may be an ad there or something that didn't load?

archon810 commented 4 years ago

OK, I just reproduced this in Chrome dev tools using mobile emulation.

Indeed, the info button above the auto inserted Google ad (thanks, Google!) doesn't do anything. @SeBsZ Can you reproduce and analyze please?

image

image

SeBsZ commented 4 years ago

@archon810 fixed in PR 1390

archon810 commented 4 years ago

Oh, so Google inserts itself in between our card and the hidden div that opens. This looks weird. Is it possible to group the two together so that Google doesn't insert things in between like that and only inserts in between cells?

image

SeBsZ commented 4 years ago

@archon810 I created PR 1393 for you that surrounds each row with a div, can you give it a try? I'm not getting the ads on my machine so I can't test this logic.

archon810 commented 4 years ago

I'll test, thanks. Are you checking the search results page without an ad blocker? Because it only does it for me there, not the homepage lists because we already inject ads on those ourselves.

archon810 commented 4 years ago

We made a tweak to the page to see if it'd fix this case, but Google stopped serving auto ads, likely due to the fact that the structure changed. I'll check back in a few days/weeks to see if the ads came back.

MihirGosai commented 4 years ago

Now, it's fixed. Screenshot_20200527-151730_Chrome