search

illogical-robot / toolbox-for-google-play-store-public

Toolbox for Google Play Store™ bugs and suggestions
110 stars 43 forks source link

Option to disable AppBrain doesn't behave as expected... #1

Closed phaseburn closed 7 years ago

phaseburn commented 7 years ago

Expected behavior

When disabling the AppBrain button, I expect it to disable the AppBrain button only, leaving the other buttons enabled or disabled according to their individual preferences...

Actual behavior

It disables all buttons, including APKMirror, and AndroidPolice, in addition to disabling the AppBrain button.

Steps to reproduce the problem

Install extension, uncheck the "Enable AppBrain button" preference from the popup, reload the browser window with a Play Store listing in it.

phaseburn commented 7 years ago

This actually seems to be a caching issue in Chrome, and a reload of the page uses cached data. A force reload of the page fixes it half the time for me. Closing/opening Chrome entirely worked after reloading the page after initially restoring the open tab. Perhaps make the Play Store page force reload upon preference change would be a good solution to this?

archon810 commented 7 years ago

I can't reproduce this. The Appbrain button doesn't load, the rest do.

Maybe something prevented the request from loading or something?

archon810 commented 7 years ago

We're currently chasing a bug where the buttons don't show up at all when many Play Store pages are open in rapid succession (or there's another variable at play?), maybe it's related to that.

archon810 commented 7 years ago

cc @corbindavenport

phaseburn commented 7 years ago

Possibly, I notice that when it happens, the beta test snippet doesn't show up, either. Though while I have 21 tabs open total, only 1 was the Play Store. So maybe it's related to tab count or something.

corbindavenport commented 7 years ago

I can't reproduce this either, but I know there's some code with how the buttons are injected that could potentially cause issues.

archon810 commented 7 years ago

This should be fixed in 1.0.10. Closing.