Add the possibility to customize some words in Attractions

illright / attractions

A pretty cool UI kit for Svelte

https://illright.github.io/attractions

MIT License

1.03k stars 37 forks source link

Add the possibility to customize some words in Attractions #315

Closed Bluzzi closed 2 years ago

Bluzzi commented 2 years ago

Hello, in the FormField (and probably in other places), there are words like "Required", "Optional". The problem is that this is not suitable for a site in French for example.

It would be cool to be able to change these words !

illright commented 2 years ago

Hi! You're right, this should definitely be added. I wish Attractions had a comprehensive localization system, but until then we can get away by just defining slots required-message and optional-message.

You're welcome to contribute by implementing this feature. Would you like that or should we implement it?

aabounegm commented 2 years ago

I tracked down the places where we have hard-coded text to make it easier for whoever wants to undertake this:

AutocompleteField:
- Line 142: "close the options"
- Line 169: "Loading" (slot exists, but for more than just the text)
- Line 193: "load more options" (slot exists, but for more than just the text; includes logic as well)
Autocomplete: Same as AutocompleteField.
- Note: why are the slots repeated and not just forwarded?
Calendar:
- Line 77: "Today, not available"
- Line 79: "Today"
- Line 84: "Not available"
FileDropzone: Lines 126-132
FileInput: Line 70
FormField:
- Line 71: "Required"
- Line 73: "Optional"

Also, should we do anything about error/warning messages in the console?

Bluzzi commented 2 years ago

Re ! Thank you for considering this problem

@illright, if you have the time to implement this, it would be cool. If not, I'll take care of it in the next few days.

@aabounegm, thanks for that list. As far as the console is concerned. All the errors have always been in English, this does not need to change !

Bluzzi commented 2 years ago

Hello, is this package still available? If I take care of this issue now, can someone review my PR and publish a new version of this package on NPM?

aabounegm commented 2 years ago

@Bluzzi Yes. We have been inactive (in terms of development) recently mainly because both of us (the maintainers) were busy with our university work, but any contribution is still welcome and we try to respond promptly.

Bluzzi commented 2 years ago

Great! I'll take care of that in the next few days