illright / attractions

A pretty cool UI kit for Svelte
https://illright.github.io/attractions
MIT License
1.03k stars 37 forks source link

svelte-preprocess 5 is available #362

Open canadaduane opened 1 year ago

canadaduane commented 1 year ago

I'm new and was following the directions from the readme to get started. I believe svelte-preprocess version 4 is required at the present time, but "latest" now defaults to 5.0. It may be helpful to others to update the readme to something like this:

npm install --save-dev svelte-preprocess@4 sass postcss
# -- or --
yarn add --dev svelte-preprocess@4 sass postcss
# -- or --
pnpm add --save-dev svelte-preprocess@4 sass postcss
aabounegm commented 1 year ago

Did you face any problems when installing v5? It seems to me that the breaking changes shouldn't affect us since we recommend installing sass and not node-sass, and while we don't explicitly specify a minimum node version, I doubt anyone who uses Svelte(Kit) has Node.js earlier than v14.

Anyways, after the WIP migration to SvelteKit (particularly, the migration from Sass to CSS), we should hopefully not need any of these dependencies.

canadaduane commented 1 year ago

It was more of a warning than a problem:

image

aabounegm commented 1 year ago

Ah, right, this should be harmless. We just need to update the allowed version range in the peer dependencies.