search

illucc / Kontraption

A addon for the Minecraft mod Mekanism that focuses on adding airships that are inspired by various space exploration/combat games (Space Engineers, Elite: Dangerous, etc)
Apache License 2.0
19 stars 10 forks source link

Spelling error #24

Closed AlexanderwithaA closed 8 months ago

AlexanderwithaA commented 8 months ago

That ain’t my name

illucc commented 8 months ago

Hi AlexanderwithaA,

Thank you for your pull request. We appreciate your effort in contributing to Kontraption. However, the request has been rejected for a couple of reasons:

  1. Commit Guidelines: Our project follows specific commit guidelines, including the use of Gitmoji for clear communication. Please refer to our contribution guidelines for more details on this.

  2. Unnecessary File Changes: The changes made, such as renaming "alexandergoodall" to "alex," could potentially confuse other users named Alex who are not associated with the project. In general, we aim to make changes that are necessary and impactful to the project.

We encourage you to review our guidelines and make the necessary adjustments to your pull request. Thank you for your understanding, and we look forward to your continued contributions.

Best regards, Illuc
Kontraption team

AlexanderwithaA commented 8 months ago

I’ve read your response and while I can add the gitmojis, I cannot justify changing the edits. Keeping my name as “alexandergoodall” would be misrepresentative of who I am. For I am just “Alex” If the confusion of others still concerns you you could change it to “Alex the editor” for that would be indicative of my roles in the Valkyrien skies discord and quite unique.

Best regards, Alex Wiki Editing Team