Closed tevwoods closed 9 months ago
Thanks so much for this. I haven't been playing a ton lately and definitely not in end game stuff so it has languished.
The PR is conflicting at the moment because the nightly build job updated the asset files. Please revert your changes to site/src/assets
and I'll be happy to approve & merge it in.
I certainly know how that goes! I'm just glad I could help out.
I removed the conflicting files, added a few more augments I missed on the first pass, and fixed a bug I had introduced late in a refactor. Should be good to go now, let me know if you need me to tweak anything
Thanks again! I'm thrilled to have someone else contributing to the site.
The site changes will be live shortly and the asset changes will be updated tonight.
Hello there!
I love your website and it has been extremely helpful in figuring out my endgame builds for the last couple of characters.
In a few cases I've run into difficulty with Dino Bone Crafting and the Lost Purpose sets from Vecna Unleashed not being implemented, which makes it difficult to keep track of things.
I took the liberty of completing your implementation of Dino Bone crafting, and adding my own implementation for the Lost Purpose sets for my own use, and thought I would offer my code up if you want to incorporate it into the website for others to use. I also made a few tweaks so that Set Augments will parse correctly and their set and set bonus will be tracked appropriately in the site.
In addition, I have fixed a couple of bugs:
Fixed: Set bonuses that gave a bonus to Well Rounded or All Ability Scores were not applying their bonus to individual Ability score affixes that were marked as important. Now set affixes will be checked to see if they are a group affix that might apply to multiple affixes.
Fixed: There were instances of "Well-Rounded" in addition to "Well Rounded", so I added a synonym for that.
Fixed: The parser was not set up to call "parse_quests" so Raid items were not updating correctly because the list of raid quests was outdated. Added a call to parse_quests in the main parse method.
Data:
I went ahead and added all (I think, I certainly may have missed some) of the augments that are currently available to the
augments.xlsx
spreadsheet.