[Bug]: Rendering transformations are applied on other curios - Githubissues

illusivesoulworks / charmofundying

Minecraft Mod: Adds curio support for the Totem of Undying so you don't have to be holding it.

https://www.curseforge.com/minecraft/mc-mods/curio-of-undying

Other

4 stars 13 forks source link

[Bug]: Rendering transformations are applied on other curios #24

Closed ochotonida closed 1 year ago

ochotonida commented 1 year ago

Minecraft Version

1.20.1

What happened?

TotemRenderer::render does not call poseStack.push/poseStack.pop, causing all curios rendered afterwards to appear in incorrect locations https://github.com/illusivesoulworks/charmofundying/blob/0c469d567bdef5f1b8e8aaec15e4c69854326bfd/common/src/main/java/com/illusivesoulworks/charmofundying/client/TotemRenderer.java#L35-L49

How do you trigger this bug?

Equip a totem of undying
Equip a second curio with a model in a slot sorted after the charm slot
The second curio will render in an incorrect location, upside down and at a smaller scale

Loader

Forge

Loader Version

Forge 47.0.16

API Version

No response

Mod Version

forge-6.4.1+1.20.1

Relevant Log Outputs

No response