search

illusivesoulworks / consecration

Minecraft Mod: Makes the undead more resilent except against fire and holy damage, and adds new features to help you slay them
https://www.curseforge.com/minecraft/mc-mods/consecration
Other
4 stars 5 forks source link

Request: Add a way for modders to register new kinds of damage as Holy #15

Closed falkreon closed 5 years ago

falkreon commented 6 years ago

I have some holy damage in my mod (Magic Arsenal) and would like to indicate that to Consecration. It seems like it'd be cleanest to accept IMCs to mark certain categories, such as "heldWeapon", "damageSource", and "potion", and retain those in registry lists so that deaths can be allowed when they match. A registry would also make configuration or minetweaker support much easier, and most of the issues I see here would be solved.

Wanted to open the discussion before a PR, but let me know if you'd be interested in a PR for something like this.

TheIllusiveC4 commented 6 years ago

Don't open a PR, because I'm planning to do some rewrites to the code base once I begin work on this mod again. I will take this suggestion into consideration though, it does sound like it could solve a lot of issues.