illusivesoulworks / consecration

Minecraft Mod: Makes the undead more resilent except against fire and holy damage, and adds new features to help you slay them
https://www.curseforge.com/minecraft/mc-mods/consecration
Other
4 stars 5 forks source link

Consecration potion effect being applied to items #73

Closed BrokenK3yboard closed 1 year ago

BrokenK3yboard commented 1 year ago

Consecration version: 1.18.2-5.0.1.2 Forge version: 1.18.2 - 40.2.0

Observed Behavior: "Consecration" potion effect is being applied to items from my mod here: https://www.curseforge.com/minecraft/mc-mods/leather-overhaul https://github.com/BrokenK3yboard/LeatherOverhaul

2023-04-12_14 01 45 2023-04-12_14 01 47

This is likely due to these items being capable storing a potion CompoundTag, as this wasn't an issue in the previous version of my mod. This is only occurring to leather armor (which is being overridden) and the one other item being added.

Possibly related to this issue: https://github.com/TheIllusiveC4/Consecration/issues/68

Expected Behavior: Consecration potion effect should not automatically apply to items.

Steps to Reproduce: Install Leather Overhaul 1.1.0 along with Consecration.

BrokenK3yboard commented 1 year ago

This issue was being caused by a Forge bug. I have fixed this on my end.