illusivesoulworks / consecration

Minecraft Mod: Makes the undead more resilent except against fire and holy damage, and adds new features to help you slay them
https://www.curseforge.com/minecraft/mc-mods/consecration
Other
4 stars 5 forks source link

[Bug]: Werewolves Silver Oil Not Holy Damage. #81

Open Virplexer opened 8 months ago

Virplexer commented 8 months ago

Minecraft Version

1.20.1

What happened?

Recently crafted Silver oil in a modpack me and my friends are playing on, was curious to see if it counted as holy damage and so tested it on a zombie, and it didn't work. Searching through the code, I noticed that there IS lines of code that detects if the weapon is oiled or not, so i imagine its an intended part of the mod. I created a new modpack with only the vampirism, werewolf, vampirism integrations, and Consecration mode and tested to see if it works, and managed to re-create the bug.

I'm pretty new to coding, but if I had to guess what the problem is, It seems as though the code for consecration checks for "weapon_oil" but when i checked the NBT data of a weapon with silver oil on it, it said "applied_oil", which i believe might be where the problem is.

How do you trigger this bug?

  1. Applied Silver oil to weapon.
  2. Attack undead using said weapon.
  3. No effect is given to undead.

Loader

Forge

Loader Version

Forge -47.2.0

API Version

N/A

Mod Version

consecration-forge-7.0.0+1.20.1

Relevant Log Outputs

No response