illusivesoulworks / consecration

Minecraft Mod: Makes the undead more resilent except against fire and holy damage, and adds new features to help you slay them
https://www.curseforge.com/minecraft/mc-mods/consecration
Other
4 stars 6 forks source link

[Feature]: Add damage type tag that bypasses the system entirely #87

Open misterghast opened 3 months ago

misterghast commented 3 months ago

What is the new feature or improvement?

While in the normal configuration for the mod, the only way to kill zombies is with holy sources, some modpacks and configurations include sources of damage that also make sense to kill zombies, but wouldn't necessarily trigger the smite status effect or vulnerability time. Laser beams that entirely disintegrate them, or supernatural effects designed specifically to deal with the undead without actually being holy or making them vulnerable. Or just holy artifacts that are holy, but not that much.

I think this could be easily implemented as an optional feature by having a damage type tag that the Undying class looks for when taking damage, and if it is present, acts the way it does when taking invulnerability bypassing damage types. The tag could be left empty as it doesn't really fit the default mod experience, and only makes more sense once other mods enter the picture.