illusivesoulworks / constructsarmory

A Tinkers' Construct add-on for those looking to enter the world of armor
https://www.curseforge.com/minecraft/mc-mods/constructs-armory
Other
54 stars 36 forks source link

Resource Pack / Custom Texture Rendering Issue #160

Closed ghost closed 5 years ago

ghost commented 5 years ago

Versions

Observed Behavior:

Custom model textures from a resource pack do not render correctly when supplied with a larger resolution than the stock Construct's Armory textures.

Expected Behavior:

Texture mapping onto Construct's Armory models should automatically scale to the source texture size when an alternate texture is provided by a resource pack.

Steps to Reproduce:

  1. Set up conarm, tconstruct, mantle on a clean forge install
  2. Activate a resource pack that contains textures for Construct's Armory in "assets/conarm/textures/models/armor/" at 2x original resolution.
  3. Create a new Creative Mode game, spawn in some torso armor, and wear it
  4. Observe the incorrect rendering in-inventory and in-world
  5. Disable the resource pack and observe the rendering return to normal.

I have included my test pack as an attachment -- these textures were generated by a simple scale and median blur with GIMP so they don't look great; I was planning on making a Faithful32-style pack for Construct's Armory but I don't want to invest a bunch of time making these look good unless the bug is possible to fix.

I'm loving the mod btw, I have a small personal server i run for friends with a custom mod pack and this addition has been very well received. Good balance and a great compliment to Tinker's. Keep up the great work :D

EDIT:

  1. fixed the zip file upload. I put it together with the wrong folder structure from my test folder. whoops.
  2. Forgot to mention that it's just the models that seem broken; all the inventory items and parts seem to render fine.

conarm-32-test.zip

front back inventory modmenu

TheIllusiveC4 commented 5 years ago

Thanks for the comprehensive bug report, I'll get back to you ASAP about whether it's possible to fix this.

TheIllusiveC4 commented 5 years ago

Surprisingly simple fix, will be released shortly.

2019-04-21_00 52 49

ghost commented 5 years ago

Holy crap thanks for the speedy response! Time to get to work on some textures :)

thecrescentkid commented 4 years ago

I'm having the same problem in the latest version of the mod 1.12.2-1.2.4