illusivesoulworks / constructsarmory

A Tinkers' Construct add-on for those looking to enter the world of armor
https://www.curseforge.com/minecraft/mc-mods/constructs-armory
Other
54 stars 36 forks source link

All armor is invisible, errors are thrown constantly, and there's a memory leak #216

Closed Brycey92 closed 4 years ago

Brycey92 commented 4 years ago

Versions (Be specific, do not write "latest"):

I'm thus far unable to reproduce with only the mods listed above. However, I'm only able to test in singleplayer currently, so the issue might still happen on a server with the short mod list above.

Expected Behavior:

Armor should render properly, and the errors should either be caught or fixed so they're not thrown in the first place.

Steps to Reproduce:

  1. Join a multiplayer server
  2. Create a full armor set with Manyullyn cores, Ardite trim, and Steel armor plating. This is the only combination tested so far, though it may happen with others.
  3. Wear it

One captured error as an example: https://gist.github.com/Brycey92/1bdc612912a19e3c882cf823ac3421e6 The lines of conarm that error referenced: https://github.com/TheIllusiveC4/ConstructsArmory/blob/master/src/main/java/c4/conarm/lib/client/DynamicTextureHelper.java#L46-L58 Entire log (something like 600MB, yikes): 2020-04-11-2.log.gz

Brycey92 commented 4 years ago

I fixed this by removing TexFix from my pack, for anyone interested.

reddvilzz commented 4 years ago

Hi, sorry for hijacking the issue. But how's the progress on this issue?

Will there a possible fix from Construct's Armory?

Brycey92 commented 4 years ago

@reddvilzz No worries! As far as I know, there's been no fix made to Construct's Armory, though the dev(s) would be able to tell you for sure.