Polishing breaks Alien trait - Githubissues

illusivesoulworks / constructsarmory

A Tinkers' Construct add-on for those looking to enter the world of armor

https://www.curseforge.com/minecraft/mc-mods/constructs-armory

Other

54 stars 36 forks source link

Polishing breaks Alien trait #254

Closed reserveword closed 3 years ago

reserveword commented 3 years ago

Versions (Be specific, do not write "latest"):

Construct's Armory: 1.2.5.9
Tinkers' Construct: 2.13.0.183
Mantle: 1.3.3.55
Forge: 14.23.5.2847
Observed Behavior:

When polishing a piece of armor with Alien trait and it is half-grown, the toughness bonus from Alien is gone.

Expected Behavior:

Alien trait stacks on top of polishing material for toughness.

Steps to Reproduce:
1. Make a Endstone helmet and it have 0 toughness
2. Wait it to grow until it is 1 toughness
3. Polish it with sponge (5 toughness)
4. It should have 6 (5 for sponge + 1 for Alien) toughness now, but it turns out to be 5 toughness
  Something Maybe Important
5. After polishing the data continues to grow from 5 like 5.01, 5.22, etc.
6. However if the armor is fully grown, the data will not change after polishing, but stops at 5 forever.
7. If you modify the armor, the data is reset to 5.

TheIllusiveC4 commented 3 years ago

Duplicate of https://github.com/TheIllusiveC4/ConstructsArmory/issues/232

As mentioned there, this is a valid issue but not one I plan on addressing since it requires a refactor for how the armor is constructed, which would break current armor implementations. I will keep this in mind for future ports though when I redesign the system.