illusivesoulworks / constructsarmory

A Tinkers' Construct add-on for those looking to enter the world of armor
https://www.curseforge.com/minecraft/mc-mods/constructs-armory
Other
54 stars 36 forks source link

Cross-mod interaction with magnets causing items to disappear in 1.12 #264

Open Random832 opened 3 years ago

Random832 commented 3 years ago

The original report in https://github.com/SlimeKnights/TinkersConstruct/issues/3857 mentions boots, so should probably have been reported here to begin with - in the analysis we determined that the same logic to calculate a velocity vector, with the same broken normalization due to the vecmath library, is duplicated in both mods.

The problem code for Construct's Armory is in https://github.com/TheIllusiveC4/ConstructsArmory/blob/master/src/main/java/c4/conarm/common/armor/traits/TraitMagnetic.java#L61