search

illusivesoulworks / culinaryconstruct

Minecraft Mod: Make custom sandwiches out of your favorite food items! And maybe your not so favorite. Anything's possible!
https://www.curseforge.com/minecraft/mc-mods/culinary-construct
Other
14 stars 11 forks source link

[1.14.4] Apple skin and Quark not showing hunger point on Culinary Construct sandwiches and bowls #34

Closed TBiscuit1 closed 2 years ago

TBiscuit1 commented 4 years ago

Versions (Be specific, do not write "latest"):

Crash Log: Please use a paste site like hastebin. No Crash

Also, I referenced this issue to the Apple Skin issues

TheIllusiveC4 commented 4 years ago

This is a bit of an odd issue. Both mods are functioning correctly. This is due to the fact that Minecraft changed the way they construct food items and these changes created a loss in ability to create dynamic food values. This is a vital feature of Culinary Construct so I had to do a workaround where I create dummy food values and directly add the correct values to the food stats myself. Apple Skin obviously can't read that, it just goes off the dummy food values that I provide.

There's not a whole lot I can do on my end, unless someone can help me figure out another workaround that creates dynamic food values in a way that passes the correct value to the food builder. From my perspective, the easiest way would be if Apple Skin provided an API or something that I can hook into to give it the right values.

TBiscuit1 commented 4 years ago

Just realized the same bug goes to Quark too, gonna tell him

TBiscuit1 commented 4 years ago

Quark Version : Quark-r2.0-212

BJZ2 commented 3 years ago

Perhaps the easiest thing you could do is to add or extend a tooltip with food/hunger and saturation info. Make it optional or change "Hold [Shift] for Ingredients" to "Hold [Shift] for Ingredients and Info".

Dr-WeiAL commented 2 years ago

Has this problem been going on for so long? 1.16.5 also has this problem

TheIllusiveC4 commented 2 years ago

This problem doesn't really have a way to solve it right now, which is why it's still an open issue. As mentioned before, this is due to the fact that Minecraft changed the way it handled food and dynamic food information currently cannot be passed to other mods due to the workaround needed.

The best solution as it is right now is what BJZ2 mentioned above adding it as a tooltip to Culinary Construct, which is what I'll be looking into in the near future. But it doesn't really solve the direct issue, which is that AppleSkin and Quark cannot receive this information without some changes either from Forge or their API.

TheIllusiveC4 commented 2 years ago

I've released an update on 1.18.2 and 1.16.5 that has new AppleSkin integration which should solve the tooltip discrepancies. I didn't realize that AppleSkin had introduced an API that allows for a fix on my end, so apologies for the wait on that.

As for Quark and potentially other mods, they don't have such an API so that will still be an ongoing issue that won't be addressed unless that changes. However, as a stopgap solution for those that aren't using AppleSkin, I've added a new configurable tooltip option that allows the sandwiches and food bowls to show their nutrition information.

Forge has recently merged a new feature that allows for dynamic food properties once again on 1.18.2, so any mod on 1.18.2 or later that encounters this issue with Culinary Construct should update to Forge 40.0.47 or later and integrate with the new food properties methods.

Dr-WeiAL commented 2 years ago

I've released an update on 1.18.2 and 1.16.5 that has new AppleSkin integration which should solve the tooltip discrepancies. I didn't realize that AppleSkin had introduced an API that allows for a fix on my end, so apologies for the wait on that.

As for Quark and potentially other mods, they don't have such an API so that will still be an ongoing issue that won't be addressed unless that changes. However, as a stopgap solution for those that aren't using AppleSkin, I've added a new configurable tooltip option that allows the sandwiches and food bowls to show their nutrition information.

Forge has recently merged a new feature that allows for dynamic food properties once again on 1.18.2, so any mod on 1.18.2 or later that encounters this issue with Culinary Construct should update to Forge 40.0.47 or later and integrate with the new food properties methods.

Haven't passed the audit yet? I don't see an update on curseforge, anyway, I'll try to build one first