illusivesoulworks / elytraslot

Minecraft Mod: Adds an accessory slot for the elytra so you can fly and wear chest armor at the same time.
https://www.curseforge.com/minecraft/mc-mods/elytra-slot
Other
46 stars 18 forks source link

Modded Enchantments not working while Elytra is equipped in the Back Slot. #30

Closed HilariousSparta closed 2 years ago

HilariousSparta commented 2 years ago

Versions:

Crash Log: No crashes, only failure to activate enchants.

TheIllusiveC4 commented 2 years ago

This is much more easily done on the side of the mod implementing the enchantments. For example, More Enchantments can add integration to check for the curios slot in addition to the armor slot when applying their behavior. Whereas to get that same integration on my end, I would need to replicate their entire enchantment logic. And I would have to do this for every mod that adds an elytra enchantment. It's just much more work, and may not even be feasible depending on how the particular enchantments are coded.

So I'd suggest making this integration request to the enchantment developers.

Edit: I should mention that labeling this as a "bug" is a bit of a misnomer, as it's expected that enchantments do not work automatically with curios. This is more aptly a feature request for the implementing mod to include optional curios slot checks in their enchantment logic.