search

illusivesoulworks / veinmining

Minecraft Mod: A lightweight, highly configurable Vein Mining enchantment for tools.
Other
30 stars 17 forks source link

[Suggestion] Add a keybind for VeinMining activation. (config option for sneak or keybind.) #7

Closed Gbergz closed 3 years ago

Gbergz commented 3 years ago

Title^

A QOL addition.

- Gbergz

64thParaDux commented 3 years ago

This would save manya bases and also many poor souls from falling into lava. I approve!

TheIllusiveC4 commented 3 years ago

So how would this work in practice? Would it only work while you are holding down the keybind, or would you use the keybind to activate/deactivate the behavior?

Gbergz commented 3 years ago

While you're holding down the keybind.

TheIllusiveC4 commented 3 years ago

Is there much difference between this proposed keybind and the current configuration option that allows you to activate it only while sneaking? It's very similar to having a keybind, it's just that it's also tied to sneaking.

I'm mainly asking that because making an actual keybind for this is trickier than it sounds and I'm not sure solely being able to choose a different keybind than sneaking is enough benefit to justify the extra overhead involved.

Gbergz commented 3 years ago

The problem with sneak activation is that sometimes you just wanna sneak to reach and mine something without falling off a block, or you're just sneaking while mining to be safe and to not fall in lava etc. And when you do that you accidentally activate Vein Mining without thinking about it(done it multiple times already).

That can be very annoying. That's why choosing a different keybind for Vein Mine activation can be very helpful.

Hope this helps.

64thParaDux commented 3 years ago

No one likes to crouch and delete half there base when they just didn't want to fall.

zanecek commented 3 years ago

Vein mining while pressing the optional key instead of pressing shift is an excellent improvement, I vote for!

TheIllusiveC4 commented 3 years ago

Just a quick update, I have decided on implementing this feature. I just need to find the time to do it since it's somewhat non-trivial.

TheIllusiveC4 commented 3 years ago

Heads up for those on the Forge version:

Because of the changes needed to accomplish this smoothly, the activationState config option has been moved to a new client-side configuration file veinmining-client.toml. It's located in the configs folder in the root folder.