search

iloire / watchmen

A simple node.js service monitor
MIT License
941 stars 199 forks source link

Log pages did not render in Safari #4

Closed emptyhammond closed 12 years ago

emptyhammond commented 12 years ago

Added callback to log render in webserver/app.js.

iloire commented 12 years ago

Hi Matt,

Thanks a lot for your contribution. It has been my mistake to use "status" as one of the objects to be sent to the view, since it is a reserved property that express.js uses to define response http status code.

So instead of applying the workaround you purpose, I refactored a bit to avoid confusions again in the future:

https://github.com/iloire/WatchMen/commit/5f6599e3ab14439051115621514945f4c3e16d84

Thanks for the heads up!!

iván

emptyhammond commented 12 years ago

Hi Iván,

Thanks thats great.

Matt

On 25 Mar 2012, at 22:49, Iván Loire wrote:

Hi Matt,

Thanks a lot for your contribution. It has been a mistake from my side to use "status" as one of the objects to be sent to the view, since it is a reserved property that express.js uses to define response http status code.

So instead of applying the workaround you purpose, I refactored a bit to avoid confusions again in the future:

https://github.com/iloire/WatchMen/commit/5f6599e3ab14439051115621514945f4c3e16d84

Thanks for the heads up!!

iván

Reply to this email directly or view it on GitHub: https://github.com/iloire/WatchMen/pull/4#issuecomment-4685091