iloire / watchmen

A simple node.js service monitor
MIT License
941 stars 199 forks source link

MemoryStore warning in production environment #48

Closed VarunBatraIT closed 8 years ago

VarunBatraIT commented 8 years ago
run-web-server-23 (err): Warning: connect.session() MemoryStore is not
run-web-server-23 (err): designed for a production environment, as it will leak
run-web-server-23 (err): memory, and will not scale past a single process.

I am getting this warning when I use production environment. I hope things are ok?

iloire commented 8 years ago

Using MemoryStore is not recommended for production environments because you can potentially ended up with memory leaks if sessions are not properly cleaned up from memory.

Adding a redis based session store would be trivial but it needs to be done preferably with breaking the storage abstraction.

iloire commented 8 years ago

Fixed with 516e940cea96dbe706fdeb36737b262cf105c491