search

ilovejs / h2database

Automatically exported from code.google.com/p/h2database
0 stars 1 forks source link

PgServer: add support for CancelRequest #475

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
At present the PgServer implementation does not currently have support for 
query cancellation; it is stubbed out and logs a warning as being not supported.

I have provided a potential implementation (with unit test) as a patch.

Original issue reported on code.google.com by arbfrank...@gmail.com on 9 Jun 2013 at 1:36

Attachments:

GoogleCodeExporter commented 9 years ago 
I've tried to make the patch relative to trunk instead of my prior patches; but 
it was a little hard in the unit test area. If you run into trouble merging 
then I can create a new patch relative to the new trunk. The patch relative to 
this issue + my recent ones is viewable at: 
https://github.com/arbfranklin/h2database/commit/ea38790fa37d1c51500902f5453e941
e85ac3ef8.

Original comment by arbfrank...@gmail.com on 9 Jun 2013 at 2:33

GoogleCodeExporter commented 9 years ago 
Patch committed

Original comment by noelgrandin on 18 Jun 2013 at 7:04

GoogleCodeExporter commented 9 years ago 
Noel, it seems like the merge of the tests might not have been as clean. I've 
also slightly revised the cancel call to not throw an exception on an invalid 
secret to match how the real PG server does it (for security reasons). Would 
you be able to re-open this ticket and I can provide a patch relative to 
current trunk?

Original comment by arbfrank...@gmail.com on 18 Jun 2013 at 9:42

GoogleCodeExporter commented 9 years ago 
Attached is the patch with the small change I described yesterday. It will no 
longer alert the caller when the secret is invalid. The patch is relative to 
trunk to make it easy to merge in.

Original comment by arbfrank...@gmail.com on 19 Jun 2013 at 9:27

Attachments: