ilovesoup / hyracks

Automatically exported from code.google.com/p/hyracks
Apache License 2.0
0 stars 0 forks source link

File Remove Operator Code Review #107

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The changes are in zheilbron/hyracks_asterix_issue316.
The changes are here: 
https://code.google.com/p/hyracks/source/detail?r=241654342ce9f76efc2dc66a3d8e0b
26b77ef47f&name=zheilbron/hyracks_asterix_issue316

Purpose of code changes on this branch:
Add the file removal operator. The use case is ASTERIX needs to delete a 
dataverse folder when a dataverse is dropped.

When reviewing my code changes, please focus on:
- Making sure I got the recursive delete correct

After the review, I'll merge this branch into:
master

Do you think there's a need for non-recursive delete? If so, I can add it.

Original issue reported on code.google.com by zheilb...@gmail.com on 10 May 2013 at 5:35

GoogleCodeExporter commented 9 years ago
Review by Vinayak: 
https://code.google.com/p/hyracks/source/detail?r=7797477e858f2d03ff37beb3c09ffd
0cd5b39c11

Original comment by zheilb...@gmail.com on 10 May 2013 at 6:17