ilovesoup / hyracks

Automatically exported from code.google.com/p/hyracks
Apache License 2.0
0 stars 0 forks source link

BufferCache.deleteFile changes for DropIndex #44

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
BufferCache.deleteFile should provide an option to NOT flush dirty pages to 
disk. A useful case is in DropIndex, where one no longer needs the index, and 
there is no need to flush dirty pages of that index to disk.  However, we DO 
need to make the dirty pages of the dropped index clean.

Original issue reported on code.google.com by buyingyi@gmail.com on 10 Nov 2011 at 9:52

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r769.

Original comment by alexande...@gmail.com on 12 Nov 2011 at 12:57

GoogleCodeExporter commented 9 years ago
This bug could actually have caused subtle data corruption! Very nice catch!

The proper fix is to guarantee that dirty pages of deleted files are never 
flushed.

I implemented the fix in my hyracks_btree_updates_next branch which will soon 
be integrated into hyracks_dev_next.

I added a corresponding regression test.

Original comment by alexande...@gmail.com on 12 Nov 2011 at 12:57