ilpersi / BHBot

A bot that automates a game called Bit Heroes
GNU General Public License v3.0
28 stars 32 forks source link

Crash after pausing and scrolling #178

Closed mikeoeo closed 4 years ago

mikeoeo commented 4 years ago

Describe the bug Bot encountered a RasterFormatException: y lies outside the raster and closed the Chromium window while I was doing a pvp battle because I accidentally scrolled the window, even though the bot should be on pause.

To Reproduce Steps to reproduce the behavior:

  1. Start bot
  2. After the game opens run command pause
  3. Scroll the window
  4. See error

Expected behavior Before v46 during pause the bot didn't do anything, now it stills does sth in the background.

Desktop (please complete the following information):

bhbot.log bhbot.log

ilpersi commented 4 years ago

Nothing has changed from v45.2 to v46 regarding pause management and it expected that the pause command is not immediate (depends on what the bot is doing).

From the logs I see that in your case it was two minutes after that is a long time. I'll try to mitigate this.

Thank you for reporting this.

mikeoeo commented 4 years ago

I usually pause it for pvp, since there's no option to select opponent based on TS *cough* *feature request* *cough*, so I wait until it doesn't do anything. Let me know if I can be of any help!

ilpersi commented 4 years ago

If you have a feature request, feel free to open a dedicated issue (choose enhancement at creation time). 🙂