enh(#4): Make Lua code optional

ilpincy / argos3

A parallel, multi-engine simulator for heterogeneous swarm robotics

http://www.argos-sim.info/

262 stars 121 forks source link

enh(#4): Make Lua code optional #106

Closed jharwell closed 3 years ago

jharwell commented 5 years ago

Makes including Lua support optional even if the required libraries are found, reducing binary size.

ilpincy commented 4 years ago

The logic of this change is not correct. If Lua is found, it should be used. The opposite default, as it is now, is not backwards compatible and will break every single repository that depends on ARGoS. I'll think a bit about this before pulling.

jharwell commented 4 years ago

I understand backwards compatability--perhaps I could make it so that it is disabled by default (i.e by default it would do the current behavior, including Lua if it was found?) Something like ARGS_FORCE_NO_LUA?

ilpincy commented 4 years ago

That would be better, but the issue is that this change should be propagated to all the other repositories, so they don't include Lua either. If we don't propagate, compilation will break for everybody. This is because of the #ifdef clauses in the control interface devices.

jharwell commented 3 years ago

This seems specific to me, and not of use to others.