search

ilpincy / argos3

A parallel, multi-engine simulator for heterogeneous swarm robotics
http://www.argos-sim.info/
262 stars 121 forks source link

Margin for detecting gimbal lock in CQuaternion::ToEulerAngles is too large #93

Closed allsey87 closed 5 years ago

allsey87 commented 5 years ago

The thresholds for detecting gimbal lock are quite large and causing glitching it the QtOpenGL visualization. Changing these thresholds from 0.499 to 0.4999 almost eliminates this issue. Is there any reason not to change these values from 0.499 to either 0.4999 or 0.49999?

a9boi

ilpincy commented 5 years ago

Is there any reason not to change these values from 0.499 to either 0.4999 or 0.49999?

No, feel free to set it to the value that is most appropriate for your simulations to be stable.

allsey87 commented 5 years ago

Ok. I'll push a fix tomorrow changing the value to: 0.49999

ilpincy commented 5 years ago

Fine for me!