Build Step withholds logs until it finishes

ilteoood / docker_buildx

GitHub actions with docker buildx

23 stars 12 forks source link

Build Step withholds logs until it finishes #2

Closed zmingxie closed 4 years ago

zmingxie commented 4 years ago

The current bash shell implementation withholds the logs until the build step finishes. This is not ideal especially when buildx could be running multi-arch builds in parallel.

Looking at another docker-builx github action (https://github.com/crazy-max/ghaction-docker-buildx), and it doesn't have this issue. Perhaps this will be an easy fix?

ilteoood commented 4 years ago

Hi, I did a quick edit from my phone. Can you make a test using the master branch?

zmingxie commented 4 years ago

Your fix indeed works! Then I noticed one more issue, and I've created a PR for it: https://github.com/ilteoood/docker_buildx/pull/3

Closing this one now.