search

ilteoood / flutter_i18n

I18n made easy, for Flutter!
MIT License
217 stars 57 forks source link

Set appropriate log levels #179

Closed vkammerer closed 2 years ago

vkammerer commented 2 years ago

Hello and thank you for the package,

This issue was already raised in https://github.com/ilteoood/flutter_i18n/issues/129 but not addressed.

The plugin currently logs a lot of "non actionable messages". This has the unfortunate effect of hiding other important logs in a sea of non actionable ones. The flutter style guide has a dedicated section about this topic: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#only-log-actionable-messages-to-the-console

Looking at the current implementation of the MessagePrinter class, it looks like it could take advantage of logging (dart core package) or logger to set appropriate log levels.

If most current logs are moved to a verbose level, it will make the warnings and errors stand out more.

ilteoood commented 2 years ago

That's really interesting. I'll take care to make it better.

As usual, PRs are welcome 😁

ilteoood commented 2 years ago

This has been fixed with the latest commit. I'll release a new version soon.

vkammerer commented 2 years ago

Thank you @ilteoood. I see you've changed your logging class and prepared everything for a new version. Is there still something that keeps you from publishing it?

ilteoood commented 2 years ago

Hi @vkammerer, nope! I've released it as version 0.31.0!